semfault/dwl
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fullscreennotify: don't crash if called before map

Browse source 
SDL2 calls xdg_toplevel.unset_fullscreen() before the surface is
mapped. This causes a segfault in dwl because setfullscreen() expects
the surface to be mapped already.
Therefore, delay the setfullscreen call until the surface is mapped.
This commit is contained in:
Raphael Robatsch 2021-11-13 17:22:52 +01:00 committed by Leonardo Hernandez Hernandez
parent 2d9740c2fc
commit 03e167dbb7
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
dwl.c
View file

@ -1042,7 +1042,13 @@ void
fullscreennotify(struct wl_listener *listener, void *data) fullscreennotify(struct wl_listener *listener, void *data)
{ {
Client *c = wl_container_of(listener, c, fullscreen); Client *c = wl_container_of(listener, c, fullscreen);
setfullscreen(c, !c->isfullscreen); struct wlr_xdg_toplevel_set_fullscreen_event *event = data;
if (!c->mon) {
/* if the client is not mapped yet, let mapnotify() call setfullscreen() */
c->isfullscreen = event->fullscreen;
return;
}
setfullscreen(c, event->fullscreen);
} }
Monitor * Monitor *
@ -1316,6 +1322,9 @@ mapnotify(struct wl_listener *listener, void *data)
/* Set initial monitor, tags, floating status, and focus */ /* Set initial monitor, tags, floating status, and focus */
applyrules(c); applyrules(c);
if (c->isfullscreen)
setfullscreen(c, 1);
} }
void void