semfault/dwl
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Delete quitfullscreen()

Browse source 
quitfullscreen() was replicating the functionalities of setfullscreen(c,
0)

Reusing setfullscreen() in quitfullscreen() leads to a 3 line function,
which is useless since quitfullscreen() is used once anyway
This commit is contained in:
Stivvo 2020-10-14 15:46:35 +02:00 committed by Guido Cella
parent 5a16649e79
commit 32612c90b6
1 changed files with 4 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
dwl.c
View file

@ -251,7 +251,6 @@ static void moveresize(const Arg *arg);
static void outputmgrapply(struct wl_listener *listener, void *data);
static void outputmgrapplyortest(struct wlr_output_configuration_v1 *config, bool test);
static void outputmgrtest(struct wl_listener *listener, void *data);
static void quitfullscreen(Client *c);
static void pointerfocus(Client *c, struct wlr_surface *surface,
double sx, double sy, uint32_t time);
static void quit(const Arg *arg);
@ -890,24 +889,6 @@ createmon(struct wl_listener *listener, void *data)
}
}
void
quitfullscreen(Client *c)
{
wl_list_for_each(c, &clients, link) {
if (c->isfullscreen && VISIBLEON(c, c->mon)) {
#ifdef XWAYLAND
if (c->type == X11Managed)
wlr_xwayland_surface_set_fullscreen(c->surface.xwayland, false);
else
#endif
wlr_xdg_toplevel_set_fullscreen(c->surface.xdg, false);
c->bw = borderpx;
resize(c, c->prevx, c->prevy, c->prevwidth, c->prevheight, 0);
c->isfullscreen = 0;
}
}
}
void
createnotify(struct wl_listener *listener, void *data)
{
@ -919,11 +900,14 @@ createnotify(struct wl_listener *listener, void *data)
if (xdg_surface->role != WLR_XDG_SURFACE_ROLE_TOPLEVEL)
return;
wl_list_for_each(c, &clients, link)
if (c->isfullscreen && VISIBLEON(c, c->mon))
setfullscreen(c, 0);
/* Allocate a Client for this surface */
c = xdg_surface->data = calloc(1, sizeof(*c));
c->surface.xdg = xdg_surface;
c->bw = borderpx;
quitfullscreen(c);
/* Tell the client not to try anything fancy */
wlr_xdg_toplevel_set_tiled(c->surface.xdg, WLR_EDGE_TOP |