semfault/dwl
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

remove useless wlr_scene_node_reparent() calls

Browse source 
These don't do anything because wlr_scene_node_reparent() is immediately
called again by setfloating() through setmon(). They are also a source
of confusion because if you change the wlr_scene_node_reparent() call in
applyrules() it takes a while to understand why it doesn't work.
This commit is contained in:
Guido Cella 2024-01-28 09:01:09 +01:00 committed by Leonardo Hernández Hernández
parent 5c936efc42
commit 45e3694fc8
No known key found for this signature in database
GPG key ID: E538897EE11B9624
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dwl.c
View file

@ -453,7 +453,6 @@ applyrules(Client *c)
} }
} }
} }
wlr_scene_node_reparent(&c->scene->node, layers[c->isfloating ? LyrFloat : LyrTile]);
setmon(c, mon, newtags); setmon(c, mon, newtags);
} }
@ -1546,7 +1545,6 @@ mapnotify(struct wl_listener *listener, void *data)
/* TODO: https://github.com/djpohly/dwl/pull/334#issuecomment-1330166324 */ /* TODO: https://github.com/djpohly/dwl/pull/334#issuecomment-1330166324 */
if (c->type == XDGShell && (p = client_get_parent(c))) { if (c->type == XDGShell && (p = client_get_parent(c))) {
c->isfloating = 1; c->isfloating = 1;
wlr_scene_node_reparent(&c->scene->node, layers[LyrFloat]);
setmon(c, p->mon, p->tags); setmon(c, p->mon, p->tags);
} else { } else {
applyrules(c); applyrules(c);