semfault/dwl
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

remove a useless check

Browse source 
if `s->role_data == NULL`, wlr_*_surface_from_wlr_surface() will return NULL
and we are checking it
This commit is contained in:
Leonardo Hernández Hernández 2022-07-15 00:48:28 -05:00
parent af12e777f2
commit e98719f552
No known key found for this signature in database
GPG key ID: E538897EE11B9624
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
client.h
View file

@ -242,11 +242,11 @@ client_from_wlr_surface(struct wlr_surface *s)
#ifdef XWAYLAND
struct wlr_xwayland_surface *xsurface;
if (s->role_data && wlr_surface_is_xwayland_surface(s)
if (wlr_surface_is_xwayland_surface(s)
&& (xsurface = wlr_xwayland_surface_from_wlr_surface(s)))
return xsurface->data;
#endif
if (s->role_data && wlr_surface_is_xdg_surface(s)
if (wlr_surface_is_xdg_surface(s)
&& (surface = wlr_xdg_surface_from_wlr_surface(s))
&& surface->role == WLR_XDG_SURFACE_ROLE_TOPLEVEL)
return surface->data;