linux/drivers/media/platform/qcom/camss
Bryan O'Donoghue a151766bd3 media: qcom: camss: Fix ordering of pm_runtime_enable
pm_runtime_enable() should happen prior to vfe_get() since vfe_get() calls
pm_runtime_resume_and_get().

This is a basic race condition that doesn't show up for most users so is
not widely reported. If you blacklist qcom-camss in modules.d and then
subsequently modprobe the module post-boot it is possible to reliably show
this error up.

The kernel log for this error looks like this:

qcom-camss ac5a000.camss: Failed to power up pipeline: -13

Fixes: 02afa816db ("media: camss: Add basic runtime PM support")
Reported-by: Johan Hovold <johan+linaro@kernel.org>
Closes: https://lore.kernel.org/lkml/ZoVNHOTI0PKMNt4_@hovoldconsulting.com/
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
2024-08-09 07:56:38 +02:00
..
camss-csid-4-1.c media: qcom: camss: Attach formats to CSID resources 2024-06-29 12:20:04 +02:00
camss-csid-4-7.c media: qcom: camss: Attach formats to CSID resources 2024-06-29 12:20:04 +02:00
camss-csid-gen1.h
camss-csid-gen2.c media: qcom: camss: Split testgen, RDI and RX for CSID 170 2024-06-29 12:20:04 +02:00
camss-csid-gen2.h
camss-csid.c media: qcom: camss: Decouple VFE from CSID 2024-06-29 12:20:04 +02:00
camss-csid.h media: qcom: camss: Decouple VFE from CSID 2024-06-29 12:20:04 +02:00
camss-csiphy-2ph-1-0.c
camss-csiphy-3ph-1-0.c
camss-csiphy.c media: qcom: camss: Attach formats to CSIPHY resources 2024-06-29 12:20:04 +02:00
camss-csiphy.h media: qcom: camss: Attach formats to CSIPHY resources 2024-06-29 12:20:04 +02:00
camss-format.c media: qcom: camss: Move format related functions 2024-06-29 12:20:04 +02:00
camss-format.h media: qcom: camss: Move format related functions 2024-06-29 12:20:04 +02:00
camss-ispif.c
camss-ispif.h
camss-vfe-4-1.c
camss-vfe-4-7.c
camss-vfe-4-8.c
camss-vfe-17x.c
camss-vfe-480.c
camss-vfe-gen1.c
camss-vfe-gen1.h
camss-vfe.c media: qcom: camss: Move format related functions 2024-06-29 12:20:04 +02:00
camss-vfe.h
camss-video.c media: qcom: camss: Remove use_count guard in stop_streaming 2024-08-09 07:56:38 +02:00
camss-video.h
camss.c media: qcom: camss: Fix ordering of pm_runtime_enable 2024-08-09 07:56:38 +02:00
camss.h media: qcom: camss: Decouple VFE from CSID 2024-06-29 12:20:04 +02:00
Kconfig
Makefile media: qcom: camss: Move format related functions 2024-06-29 12:20:04 +02:00