refactor: ♻️ Use .replaceAll instead of /g

src/server/index.ts

@@ -1,14 +1,14 @@
-import cookieParser from "cookie-parser";
+import cookieParser from "cookie-parser"
 import { IntentsBitField, Client } from "discord.js"
 import express from "express"
 import fs from "fs"
-import bytes from "bytes";
+import bytes from "bytes"
 
 import ServeError from "./lib/errors"
 import Files from "./lib/files"
 import * as auth from "./lib/auth"
 import * as Accounts from "./lib/accounts"
-import { getAccount } from "./lib/middleware";
+import { getAccount } from "./lib/middleware"
 
 import APIRouter from "./routes/api"
 
@@ -30,31 +30,38 @@ app.use(cookieParser())
 if (config.trustProxy) app.enable("trust proxy")
 if (config.forceSSL) {
     app.use((req, res, next) => {
-        if (req.protocol == "http") res.redirect(`https://${req.get("host")}${req.originalUrl}`)
+        if (req.protocol == "http")
+            res.redirect(`https://${req.get("host")}${req.originalUrl}`)
         else next()
     })
 }
 
 app.get("/server", (req, res) => {
-    res.send(JSON.stringify({
+    res.send(
+        JSON.stringify({
             ...config,
             version: pkg.version,
-        files:Object.keys(files.files).length
+            files: Object.keys(files.files).length,
-    }))
+        })
+    )
 })
 
 // funcs
 
 // init data
 
-if (!fs.existsSync(__dirname+"/../.data/")) fs.mkdirSync(__dirname+"/../.data/")
+if (!fs.existsSync(__dirname + "/../.data/"))
+    fs.mkdirSync(__dirname + "/../.data/")
 
 // discord
 
-let client = new Client({intents:[
+let client = new Client({
+    intents: [
         IntentsBitField.Flags.GuildMessages,
-    IntentsBitField.Flags.MessageContent
+        IntentsBitField.Flags.MessageContent,
-],rest:{timeout:config.requestTimeout}})
+    ],
+    rest: { timeout: config.requestTimeout },
+})
 
 let files = new Files(client, config)
 
@@ -73,7 +80,6 @@ app.get("/", function(req,res) {
 // serve download page
 
 app.get("/download/:fileId", getAccount, (req, res) => {
-    
     let acc = res.locals.acc as Accounts.Account
 
     if (files.getFilePointer(req.params.fileId)) {
@@ -85,69 +91,100 @@ app.get("/download/:fileId", getAccount, (req,res) => {
         }
 
         fs.readFile(process.cwd() + "/pages/download.html", (err, buf) => {
-            let fileOwner = file.owner ? Accounts.getFromId(file.owner) : undefined;
+            let fileOwner = file.owner
-            if (err) {res.sendStatus(500);console.log(err);return}
+                ? Accounts.getFromId(file.owner)
+                : undefined
+            if (err) {
+                res.sendStatus(500)
+                console.log(err)
+                return
+            }
             res.send(
-                buf.toString()
+                buf
-                .replace(/\$FileId/g,req.params.fileId)
+                    .toString()
-                .replace(/\$Version/g,pkg.version)
+                    .replaceAll("$FileId", req.params.fileId)
-                .replace(/\$FileSize/g,file.sizeInBytes ? bytes(file.sizeInBytes) : "[File size unknown]")
+                    .replaceAll("$Version", pkg.version)
-                .replace(/\$FileName/g,
+                    .replaceAll(
-                    file.filename
+                        "$FileSize",
-                        .replace(/\&/g,"&")
+                        file.sizeInBytes
-                        .replace(/\</g,"&lt;")
+                            ? bytes(file.sizeInBytes)
-                        .replace(/\>/g,"&gt;")
+                            : "[File size unknown]"
                     )
-                .replace(/\<\!\-\-metaTags\-\-\>/g,
+                    .replaceAll(
-                    (
+                        "$FileName",
-                        file.mime.startsWith("image/") 
+                        file.filename
+                            .replaceAll("&", "&amp;")
+                            .replaceAll("<", "&lt;")
+                            .replaceAll(">", "&gt;")
+                    )
+                    .replace(
+                        "<!--metaTags-->",
+                        (file.mime.startsWith("image/")
                             ? `<meta name="og:image" content="https://${req.headers.host}/file/${req.params.fileId}" />`
-                        : (
+                            : file.mime.startsWith("video/")
-                            file.mime.startsWith("video/")
+                            ? `<meta property="og:video:url" content="https://${
-                            ? (
+                                  req.headers.host
-                                `<meta property="og:video:url" content="https://${req.headers.host}/cpt/${req.params.fileId}/video.${file.mime.split("/")[1] == "quicktime" ? "mov" : file.mime.split("/")[1]}" />
+                              }/cpt/${req.params.fileId}/video.${
-                                <meta property="og:video:secure_url" content="https://${req.headers.host}/cpt/${req.params.fileId}/video.${file.mime.split("/")[1] == "quicktime" ? "mov" : file.mime.split("/")[1]}" />
+                                  file.mime.split("/")[1] == "quicktime"
+                                      ? "mov"
+                                      : file.mime.split("/")[1]
+                              }" />
+                                <meta property="og:video:secure_url" content="https://${
+                                    req.headers.host
+                                }/cpt/${req.params.fileId}/video.${
+                                  file.mime.split("/")[1] == "quicktime"
+                                      ? "mov"
+                                      : file.mime.split("/")[1]
+                              }" />
                                 <meta property="og:type" content="video.other">
                                 <!-- honestly probably good enough for now -->
-                                <meta property="twitter:image" content="0">`
+                                <meta property="twitter:image" content="0">` +
                               // quick lazy fix as a fallback
                               // maybe i'll improve this later, but probably not.
-                                + ((file.sizeInBytes||0) >= 26214400 ? `
+                              ((file.sizeInBytes || 0) >= 26214400
+                                  ? `
                                 <meta property="og:video:width" content="1280">
-                                <meta property="og:video:height" content="720">` : "")
+                                <meta property="og:video:height" content="720">`
-                            )
+                                  : "")
-                            : ""
+                            : "") +
-                        )
+                            (fileOwner?.embed?.largeImage &&
-                    )
+                            file.visibility != "anonymous" &&
-                    + (
+                            file.mime.startsWith("image/")
-                        fileOwner?.embed?.largeImage && file.visibility!="anonymous" && file.mime.startsWith("image/")
                                 ? `<meta name="twitter:card" content="summary_large_image">`
-                        : ""
+                                : "") +
+                            `\n<meta name="theme-color" content="${
+                                fileOwner?.embed?.color &&
+                                file.visibility != "anonymous" &&
+                                (req.headers["user-agent"] || "").includes(
+                                    "Discordbot"
                                 )
-                    + `\n<meta name="theme-color" content="${fileOwner?.embed?.color && file.visibility!="anonymous" && (req.headers["user-agent"]||"").includes("Discordbot") ? `#${fileOwner.embed.color}` : "rgb(30, 33, 36)"}">`
+                                    ? `#${fileOwner.embed.color}`
+                                    : "rgb(30, 33, 36)"
+                            }">`
                     )
-                .replace(/\<\!\-\-preview\-\-\>/g,
+                    .replace(
+                        "<!--preview-->",
                         file.mime.startsWith("image/")
                             ? `<div style="min-height:10px"></div><img src="/file/${req.params.fileId}" />`
-                    : (
+                            : file.mime.startsWith("video/")
-                        file.mime.startsWith("video/")
                             ? `<div style="min-height:10px"></div><video src="/file/${req.params.fileId}" controls></video>`
-                        : (
+                            : file.mime.startsWith("audio/")
-                            file.mime.startsWith("audio/")
                             ? `<div style="min-height:10px"></div><audio src="/file/${req.params.fileId}" controls></audio>`
                             : ""
                     )
+                    .replaceAll(
+                        "$Uploader",
+                        !file.owner || file.visibility == "anonymous"
+                            ? "Anonymous"
+                            : `@${fileOwner?.username || "Deleted User"}`
                     )
             )
-                .replace(/\$Uploader/g,!file.owner||file.visibility=="anonymous" ? "Anonymous" : `@${fileOwner?.username || "Deleted User"}`)
-            )
         })
     } else {
         ServeError(res, 404, "file not found")
     }
 })
 
-
 /*
     routes should be in this order:
     

src/server/lib/errors.ts

@@ -31,8 +31,8 @@ export default async function ServeError(
     res.header("x-backup-status-message", reason) // glitch default nginx configuration
     res.send(
         errorPage
-            .replace(/\$code/g,code.toString())
+            .replaceAll("$code",code.toString())
-            .replace(/\$text/g,reason)
+            .replaceAll("$text",reason)
     )
 }
 /**

src/server/lib/mail.ts

@@ -1,21 +1,16 @@
-import { createTransport } from "nodemailer";
+import { createTransport } from "nodemailer"
 
 // required i guess
 require("dotenv").config()
 
-let
+let mailConfig = require(process.cwd() + "/config.json").mail,
-mailConfig = 
+    transport = createTransport({
-    require( process.cwd() + "/config.json" ).mail,
-transport =
-    createTransport(
-        {
         ...mailConfig.transport,
         auth: {
             user: process.env.MAIL_USER,
-                pass: process.env.MAIL_PASS
+            pass: process.env.MAIL_PASS,
-            }
+        },
-        }
+    })
-    )
 
 // lazy but
 
@@ -30,11 +25,15 @@ export function sendMail(to: string, subject: string, content: string) {
     return transport.sendMail({
         to,
         subject,
-        "from": mailConfig.send.from,
+        from: mailConfig.send.from,
-        "html": `<span style="font-size:x-large;font-weight:600;">monofile <span style="opacity:0.5">accounts</span></span><br><span style="opacity:0.5">Gain control of your uploads.</span><hr><br>${
+        html: `<span style="font-size:x-large;font-weight:600;">monofile <span style="opacity:0.5">accounts</span></span><br><span style="opacity:0.5">Gain control of your uploads.</span><hr><br>${content
-            content
+            .replaceAll(
-                .replace(/\<span username\>/g, `<span code><span style="color:#DDAA66;padding-right:3px;">@</span>`)
+                "<span username>",
-                .replace(/\<span code\>/g,`<span style="font-family:monospace;padding:3px 5px 3px 5px;border-radius:8px;background-color:#1C1C1C;color:#DDDDDD;">`)
+                `<span code><span style="color:#DDAA66;padding-right:3px;">@</span>`
-        }<br><br><span style="opacity:0.5">If you do not believe that you are the intended recipient of this email, please disregard this message.</span>`
+            )
+            .replaceAll(
+                "<span code>",
+                `<span style="font-family:monospace;padding:3px 5px 3px 5px;border-radius:8px;background-color:#1C1C1C;color:#DDDDDD;">`
+            )}<br><br><span style="opacity:0.5">If you do not believe that you are the intended recipient of this email, please disregard this message.</span>`,
     })
 }

tsconfig.json

@@ -12,7 +12,7 @@
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
 
     /* Language and Environment */
-    "target": "es2016",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "es2022",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     // "lib": [],                                        /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */