semfault/dwl
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
993 commits 2 branches 0 tags 1.5 MiB
Commit graph

771 commits

Author SHA1 Message Date
Leonardo Hernández Hernández 71c7e4e1e5
also update locked_bg node position in updatemons() 2022-12-30 14:25:19 -06:00
Leonardo Hernández Hernández 72d29f1654
add blank lines to make updatemons() more readable 2022-12-30 14:21:46 -06:00
Leonardo Hernández Hernández e523c2b82b
update comment about client_set_size() as no-op 2022-12-30 14:19:47 -06:00
Leonardo Hernández Hernández 6d0e3a5198
check if a client is resizing before checking if it's visible 
It's not like it's noticeable, but theoretically this is faster
 2022-12-30 14:15:21 -06:00
Leonardo Hernández Hernández 5347ed663d
only mark pending resizes as completed checking the configure serial 2022-12-30 14:14:06 -06:00
Leonardo Hernández Hernández 6ca011430a
do not skip frames if a client is stopped and have a pending resize 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández 7eaa01ac1f
Revert "Revert "fix flickering when resizing/spawning windows"" 
This reverts commit 4a32293548.
 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández 92e7752203
disable client's scene node after create it (only XDGShell) 
will be enabled when setting up its monitor and arrange it

Bug: https://github.com/djpohly/dwl/issues/306
 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández 6682878009
call arrange() or resize() depending on c->isfloating in commitnotify 2022-12-24 16:43:31 -06:00
Leonardo Hernández Hernández afacc9b0b5
force SSD when creating an xdg_toplevel_decoration object 
Closes: https://github.com/djpohly/dwl/issues/366
Not sure why GLFW apps do not get mapped when we do not tell them the
decoration method
 2022-12-20 21:53:45 -06:00
Leonardo Hernández Hernández dd9d8d543c
remove selclient() 
selclient() does not work well when dealing newly mapped
clients (specifically those mapped on invisible tags).

This fixes various bugs related to things not working because selclient() would
return NULL.

References: 94c8bd6048
 2022-12-20 21:27:14 -06:00
Leonardo Hernández Hernández 686958a4cc
fix unset fullscreen for all visible clients when mapping a new one 
this also changes our policy about when we unset fullscreen:

dwl will unset fullscreen for clients who share tags (and monitor) with a newly
mapped client, it does not matter if the clients are visible or not
 2022-12-20 21:21:40 -06:00
Leonardo Hernández Hernández 1a3d89e5b2
call checkidleinhibitor() in arrange() and not in focusclient() 2022-12-16 18:54:33 -06:00
Leonardo Hernández Hernández 7b1fe7e5f2
fix checking idle inhibit state 
checking `bypass_surface_visibility` first, could cause that even if the idle
inhibitor is being destroyed it will disable idle tracking

and if we couldn't get its scene tree, then assume that the surface is visible
 2022-12-16 17:37:18 -06:00
Leonardo Hernández Hernández 803a9ba98d
Revert "Revert "Check that inhibitor scene tree is not null"" 
This reverts commit 035bb99d67.

Not checking `tree != NULL` result in a segfault if the surface doesn't have a
role (for example because it is a newly created surface)

Closes: https://github.com/djpohly/dwl/issues/359
 2022-12-16 17:20:59 -06:00
Leonardo Hernández Hernández 94c8bd6048
get sel from focustop() in focusstack() 
Fixes: https://github.com/djpohly/dwl/issues/354
 2022-12-09 20:55:58 -06:00
Leonardo Hernández Hernández c60f651951
Revert "force line-buffered stdout if stdout is not a tty" 
This reverts commit deb48ff48b.

Fixes: https://github.com/djpohly/dwl/issues/253
 2022-12-09 08:46:22 -06:00
Leonardo Hernández Hernández 79b051f242
implement ext-session-lock-v1 2022-12-06 14:11:41 -06:00
Leonardo Hernández Hernández d42a977b5b
Revert "remove unneeded changes in commitnotify()" 
This reverts commit 30c24a53ad.

Bug: https://github.com/djpohly/dwl/issues/349
 2022-12-06 13:59:14 -06:00
Leonardo Hernández Hernández 4a32293548
Revert "fix flickering when resizing/spawning windows" 
This reverts commit 017bb7d752.

Bug: https://github.com/djpohly/dwl/issues/349
 2022-12-06 13:58:56 -06:00
Leonardo Hernández Hernández 9136b6247d
return early if couldn't find the popup's parent 2022-12-06 13:34:35 -06:00
Leonardo Hernández Hernández 19b5d47a9e
fix popups appearing outside the monitor 
and a potentially crash
 2022-12-06 13:31:48 -06:00
Leonardo Hernández Hernández 22336612ae
improve type safety of toplevel_from_wlr_surface() 2022-12-05 23:18:02 -06:00
Leonardo Hernández Hernández 38bd00351a
merge toplevel_from_{wlr_layer_surface,popup} into client_from_wlr_surface 
now it is a big function called toplevel_from_wlr_surface
 2022-12-05 23:18:01 -06:00
Leonardo Hernández Hernández 13b929d7d7
remove unneeded call to wlr_scene_rect_set_color() 
wlr_scene_rect_create() requires a color as parameter
 2022-12-05 23:06:53 -06:00
Leonardo Hernández Hernández b6d6127733
add option for set button map 2022-12-05 22:22:49 -06:00
Dima Krasner 16a49e9955 fix null deref in sigchld() if Xwayland is disabled 2022-12-03 13:30:30 -06:00
Palanix 30c24a53ad
remove unneeded changes in commitnotify() 2022-12-03 13:14:10 -06:00
Palanix 017bb7d752
fix flickering when resizing/spawning windows 
Fixes: https://github.com/djpohly/dwl/issues/306
 2022-12-03 13:14:10 -06:00
Leonardo Hernández Hernández fac3b6f2cf
use root surfaces to check idle inhibitors 
References: https://github.com/djpohly/dwl/pull/343
 2022-12-02 23:25:46 -06:00
Leonardo Hernández Hernández 035bb99d67
Revert "Check that inhibitor scene tree is not null" 
This reverts commit 9c155eefdc.

This commit was applied just a workaround, the proper fix is the next commit
 2022-12-02 23:25:04 -06:00
Ben Jargowsky 9c155eefdc Check that inhibitor scene tree is not null 2022-12-02 15:10:25 -06:00
Leonardo Hernández Hernández eaf8a21603
unset fullscreen when mapping a client in the same monitor 
Fixes: https://github.com/djpohly/dwl/issues/327
 2022-12-02 10:09:50 -06:00
Leonardo Hernández Hernández ce1d040586
Merge branch 'main' of github.com:djpohly/dwl 2022-12-02 10:06:40 -06:00
Leonardo Hernández Hernández 6df6781b43
simplify check for surface's node state 
all `struct wlr_surface` should have a `wlr_scene_tree *` as data
 2022-11-30 18:54:54 -06:00
Leonardo Hernández Hernández 10c56d6348
add option to allow invisible surfaces to disable idle tracking 2022-11-30 18:51:35 -06:00
Leonardo Hernández Hernández c91d21b68f
do not move/resize if grabbed client is fullscreen 2022-11-30 17:54:47 -06:00
Leonardo Hernández Hernández 3213088aa2
do not try to set the parent's same tags and monitor for xwayland clients 
References: https://github.com/djpohly/dwl/pull/334#issuecomment-1330166324
 2022-11-30 17:42:58 -06:00
krypek 87d87cc404 Fix comparison between signed and unsigned int 
When c->bw is 0, the right side of the MAX functions gets turned into an unsigned integer and that results in -1 being the outcome.
This causes big issues in xwayland clients.
 2022-11-25 12:09:35 -06:00
Leonardo Hernández Hernández 087373698a
Revert "Add a configuration option for fullscreen locking" 
now all fullcreen clients are rendered above tiled and floating clients

This partially reverts commit 326eee1444.
 2022-11-21 20:50:39 -06:00
Leonardo Hernández Hernández caec566286
create a dedicated layer for fullscreen clients 
Bug: https://github.com/djpohly/dwl/issues/327
 2022-11-21 20:50:26 -06:00
Leonardo Hernández Hernández 05eca0e2d9
rename xwayland_surface to xsurface 
this save us 2 lines
 2022-11-21 14:28:05 -06:00
Leonardo Hernández Hernández 7eebe67787
set x and y of the layersurface's geometry box 2022-11-21 14:28:05 -06:00
Leonardo Hernández Hernández 63d6de5866
fix set of layersurface->popups and surface->data 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández 60a98b87f3
inhibit idle if surface's node is enabled 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández 93a911d6e9
simplify if expression in checkidleinhibitor() 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández 88d386bfdc
configurex11: resize floating clients and arrange tiled clients' monitor 2022-11-21 14:27:57 -06:00
Leonardo Hernández Hernández 972e3f3050
Merge branch 'wlroots-next' into main 2022-11-21 14:16:55 -06:00
Leonardo Hernández Hernández 569f554016
don't unfocus focused client when starting a drag 
this fix chromium keyboard focus loss after a drag
Fix: 3cc22de712
 2022-11-19 01:34:15 -06:00
Leonardo Hernández Hernández fcb3fa4e90
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-11-10 23:25:48 -06:00
shua f1639ba9d5
check null in toplevel_from_popup 
managed to SEGFAULT the server by trying to create a popup
without setting a parent first.

Not sure if this is dwl or wlroots issue, so also opened a ticket upstream: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3811
 2022-11-09 00:01:50 -06:00
Leonardo Hernández Hernández 8bd3442575
layersurface: create a dedicated scene tree for popups 
this tree should be always above the top layer

Fixes: https://github.com/djpohly/dwl/issues/328
 2022-11-01 12:52:25 -06:00
Leonardo Hernández Hernández 3cc22de712
client: don't change border color during drags 
Fixes: https://github.com/djpohly/dwl/issues/318
 2022-10-31 23:46:02 -06:00
Leonardo Hernández Hernández 448a96de13
remove now unneeded workaround in outputmgrapplyortest() 2022-10-30 01:03:44 -05:00
Leonardo Hernández Hernández 99f062273e
only destroy monitor's layer surfaces at destroy 2022-10-29 19:02:44 -05:00
Leonardo Hernández Hernández 8298f20a71
allow change adaptive sync in outputmgrapplyortest() 2022-10-29 18:30:09 -05:00
Leonardo Hernández Hernández 6a0ec2a8c3
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-10-29 18:11:28 -05:00
Leonardo Hernández Hernández 846ce52b92 fix crash in dirtomon() when selmon is disabled 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández a9e2ebaf41 closemon() now updates selmon if needed 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández 9b5f0f0fc5 use just one loop in outputmgrapplyortest() 
we do the magic in updatemons()
 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández cb01ce9bcf move focus and clients off disabled monitors 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández 9588b46b5c
only raise the client's node in monocle() 
Fixes: https://github.com/djpohly/dwl/issues/326
 2022-10-29 16:47:17 -05:00
Leonardo Hernández Hernández 1eeb3689d3
add support for the ext-idle-notify-v1 protocol 
for now we use macros to support both KDE idle and ext-idle, wlroots will
likely drop support for KDE idle in 0.17
 2022-10-23 14:41:28 -05:00
Leonardo Hernández Hernández e9826de295
Revert "stop trying resize clients during commitnotify()" 
This reverts commit 2d9d758c8d.

wasn't meant to be pushed to main
 2022-10-15 18:25:58 -05:00
Leonardo Hernández Hernández 110cde8f67
update comment about exclusive focus in focusclient() 2022-10-15 18:09:42 -05:00
Leonardo Hernández Hernández 2d9d758c8d
stop trying resize clients during commitnotify() 
instead resize them in configurex11()
 2022-10-15 18:00:55 -05:00
Leonardo Hernández Hernández 332ceb7136 allow unmanaged clients (like dzen or dmenu) to have keyboard focus 2022-10-15 18:00:24 -05:00
Leonardo Hernández Hernández 4eabf6f7eb
disable and destroy monitor's layer surfaces when it's being destroyed 
Fixes: https://github.com/djpohly/dwl/issues/314
 2022-10-11 13:11:14 -05:00
Leonardo Hernández Hernández 765656902f
use /* */ for comments in applybounds() 2022-10-08 20:51:40 -05:00
Leonardo Hernández Hernández 1438dfc150
fix bad indentation in createpointer() 2022-10-08 20:51:05 -05:00
Leonardo Hernández Hernández 3902fba769
rename dragicondestroy() -> destroydragicon() 
to match the rest of the code
 2022-10-08 20:50:17 -05:00
Leonardo Hernández Hernández 7f3c9fa0ae
rename LyrNoFocus -> LyrDragIcon 2022-10-08 20:48:48 -05:00
Leonardo Hernández Hernández 952fde68a3
correctly handle cursor motion when button is held (for layer surfaces) 2022-10-08 13:02:43 -05:00
Dima Krasner 0d1ca4663c
allow moveresize() while the left mouse button is pressed 
Fixes: https://github.com/djpohly/dwl/issues/319
 2022-10-08 12:31:29 -05:00
Leonardo Hernández Hernández f6820a6c29
fix drag and drop not working 
this fixes another issue where the cursor doesn't change when selecting text
but there is still an issue about not changing border color of clients during
dnd operations

Bug: https://github.com/djpohly/dwl/issues/318
 2022-10-07 10:45:45 -05:00
Leonardo Hernández Hernández 8559141b30
avoid usage of goto 
Based on this suggestion: bc72af6e24 (commitcomment-85592855)
 2022-10-03 23:28:58 -05:00
Leonardo Hernández Hernández 434ed119f3
wlroots check map state of layersurfaces this for us 2022-10-01 23:33:17 -05:00
Leonardo Hernández Hernández ae3d435717
Merge remote-tracking branch 'djpohly/main' into wlroots-next 2022-10-01 23:30:47 -05:00
Leonardo Hernández Hernández b8bc54b65d properly handle cursor motion when button is held 
Based on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3653
 2022-10-01 23:10:54 -05:00
Leonardo Hernández Hernández b5776e5180
avoid setting duplicate cursor image 
Reference: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3436
Based on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3595
 2022-09-28 17:11:04 -05:00
Leonardo Hernández Hernández c13d948ea9
destroy renderer and allocator in cleanup() 2022-09-28 14:15:25 -05:00
Leonardo Hernández Hernández fc8b2a8335
fix bad condition 2022-09-26 20:31:36 -05:00
Leonardo Hernández Hernández c00faae263
fix various segfaults when selmon is NULL 2022-09-26 19:07:45 -05:00
Leonardo Hernández Hernández e46238b95e
change cursor surface in internal calls of motionnotify() 
and call motionnotify() after unmapping a client
and when focusing a client

Fixes: https://github.com/djpohly/dwl/issues/308
 2022-09-26 13:17:07 -05:00
Leonardo Hernández Hernández 2385d82612
remove unused variables 2022-09-20 23:40:35 -05:00
Leonardo Hernández Hernández 1fdc65ff93
make more permissive exclusive focus 
now you can call focusstack() while a layer surface is focused and when it gets
unmapped the newly focused clients will be actually focused
 2022-09-18 17:25:12 -05:00
Leonardo Hernández Hernández fbaeb85363
now really fix clients not being focused after unmapping a layer surface 2022-09-18 17:23:07 -05:00
Leonardo Hernández Hernández 570e6e2c27
fix clients not being focused after destroy a layer surface 2022-09-18 16:52:54 -05:00
Leonardo Hernández Hernández a1b33826cf
Revert "remove useless check of m in arrangelayers()" 
This partially reverts commit d14ee99661.

Checking if the output is enabled is necessary to avoid a segfault later
 2022-09-18 16:36:38 -05:00
Leonardo Hernández Hernández d14ee99661
remove useless check of m in arrangelayers() 
it is supossed to avoid a crash when we pass m=NULL as argument
however it would crash anyway and also because we should not pass m=NULL
 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández cd96f889b8
fix use of loop initial declaration 
forbidden by the suckless style
 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández bc72af6e24
fix unmanaged clients not being unlinked from the commit listener 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández bcc8ce7a40
fix segfault when unlocking swaylock on two monitor setup 
wlr_*_surface_from_wlr_surface() can return NULL if the surface
is being destroyed

Fixes: https://github.com/djpohly/dwl/issues/305
 2022-09-18 15:35:54 -05:00
Leonardo Hernández Hernández ba7dcb2dea
don't try to move outputs when its x,y hasn't change 
when using wlr_output_layout_move() wlroots internally
change the state of the output to manually configured and
when updating the layout these outputs aren't ignored by
wlroots, leaving us at our own
 2022-09-10 23:54:57 -05:00
Leonardo Hernández Hernández c8a9f63451
prior run the startup command start the backend 
this allow use clients like wlr-randr in the startup command
 2022-09-10 23:54:56 -05:00
Leonardo Hernández Hernández fd67087a82
make sure the parent is mapped prior set monitor and tags 2022-09-10 23:45:14 -05:00
Leonardo Hernández Hernández 77ba8e5127
use wl_container_of() instead of data in some functions 2022-09-10 23:44:19 -05:00
Leonardo Hernández Hernández c509046663
add some comments 2022-09-10 23:42:58 -05:00
Leonardo Hernández Hernández 93de6e82a2
inline input_device in virtualkeyboard() 2022-09-10 22:25:46 -05:00
Leonardo Hernández Hernández f8f94c97f5
fix idle inhibitor check 
previously we tried to get a client from the surface and then compare it with
the excluded surface, if we cannot get a client from the surface (e.g: a layer
surface) it just ignored all the next idle inhibitors no matter what

What I have should done is just checking if the excluded surface is equal to
the current idle inhibitor's surface and continue in case it is.
 2022-09-10 22:11:06 -05:00