semfault/dwl
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
1271 commits 2 branches 0 tags 1.5 MiB
Commit graph

982 commits

Author SHA1 Message Date
link2xt b4da97446a createkeyboard: do not segfault if xkb_keymap_new_from_names returns NULL 
Passing NULL to wlr_keyboard_set_keymap results in a segfault.
Example:

  Thread 1 "dwl" received signal SIGSEGV, Segmentation fault.
  0x00007ffff7e49b64 in xkb_keymap_ref () from /usr/lib/libxkbcommon.so.0
  (gdb) bt
  #0  0x00007ffff7e49b64 in xkb_keymap_ref () at /usr/lib/libxkbcommon.so.0
  #1  0x00007ffff7f06389 in wlr_keyboard_set_keymap () at /usr/lib/libwlroots.so.11
  #2  0x000055555555bc54 in createkeyboard ()
  #3  0x000055555555c283 in inputdevice ()
  #4  0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0
  #5  0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0
  #6  0x00007ffff7edb52c in  () at /usr/lib/libwlroots.so.11
  #7  0x00007ffff7ee44b6 in  () at /usr/lib/libwlroots.so.11
  #8  0x000055555555fe66 in main ()
 2023-11-19 01:14:35 -06:00
Leonardo Hernández Hernández 2751a6195d
do not try to enable adaptive sync 2023-11-18 11:20:56 -06:00
Leonardo Hernández Hernández fcf324be6c
fix the position of the cursor image after turning all the monitors on 2023-11-17 19:03:23 -06:00
Leonardo Hernández Hernández b8e933b9a9
remove unused #include 2023-11-17 11:03:33 -06:00
Leonardo Hernández Hernández 1044a21555
do not check if session is non-NULL 
wlr_session_change_vt() is a no-op if session == NULL
 2023-11-17 11:03:33 -06:00
Leonardo Hernández Hernández 6bcd5d8d87
do not explicitly destroy some wlroots interfaces 
they are destroyed when the wayland display is destroyed
 2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández e95f14541a
fix docs 
copied from tinywl
 2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández bca1b779aa
fix destroynotify() docs 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4421
 2023-11-17 11:03:32 -06:00
Leonardo Hernández Hernández 4f4c540bb9
prevent a use-after-free at exit 2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández 8e3f5364d3
do not compute layout box twice 2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández 2212363225
make sure fullscreen clients have the right size 2023-11-17 11:03:30 -06:00
Leonardo Hernández Hernández 6f8a3f9374
fix screen artifacts when setting gamma 
the artifacts were caused because we tried to set the gamma right after
receiving the event, this resulted in two pending page-flips, which
not always play well together.

This also seems to fix a screen freeze when turning on a monitor that has
gamma.

Additionally the current method won't work once [0] is merged

[0]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4423
 2023-11-17 11:01:30 -06:00
Leonardo Hernández Hernández e1f3983bf8
use wlr_scene_subsurface_tree_set_clip 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4131
Closes: https://github.com/djpohly/dwl/issues/411
 2023-11-14 19:44:43 -06:00
Leonardo Hernández Hernández 31bf1cbaf6
Revert "respect size hints" 
This reverts commit 72e0a560d9.
 2023-11-14 19:44:28 -06:00
Leonardo Hernández Hernández a4a83e95e6
use newer cursor naming spec 
References: https://www.freedesktop.org/wiki/Specifications/cursor-spec/
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4416
 2023-11-01 12:28:19 -06:00
Leonardo Hernández Hernández e45ded7eea
ignore maximize events for clients using xdg-shell v5 and newer 2023-11-01 12:16:02 -06:00
Leonardo Hernández Hernández 892a4d3ec7
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-10-13 17:10:25 -06:00
Ben Collerson 8c79f8dc15
check client is mapped before setting border color 
For some reason brave configured for as a wayland client triggers this code on startup and segfaults.

Checking if the client is mapped fixes this, like with the previous fix for urgent border colour.

References: 887fde65a3
Fixes: 72a7d78a1a
 2023-10-10 10:16:11 -06:00
Leonardo Hernández Hernández 8781f4dbf5
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-10-09 22:37:36 -06:00
Leonardo Hernández Hernández df131cdb78
use <xcb/xcb.h> instead of <X11/Xlib.h> 2023-10-09 22:33:37 -06:00
Leonardo Hernández Hernández 887fde65a3
only set border color for urgent *and* mapped X11 clients 
this fixes a segfault when the client emits .set_hints but it's not mapped

Fixes: 72a7d78a1a
 2023-10-09 22:32:15 -06:00
Leonardo Hernández Hernández b299e01e44
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-10-09 11:45:51 -06:00
Leonardo Hernández Hernández 6d9a915fb6
Revert "just add define" 
I'm going to make some changes in the config file anyway

This reverts commit e5367753bb.
 2023-10-09 11:12:24 -06:00
Leonardo Hernández Hernández 935b852dc5
add [-d] flag to enable debug logging 2023-10-09 11:11:33 -06:00
Leonardo Hernández Hernández a18c528300
simplify setting the border color of clients 2023-10-09 11:05:41 -06:00
Leonardo Hernández Hernández 72a7d78a1a
make the borders red borders for urgent clients 
iirc this is the same behavior of dwm
 2023-10-09 11:04:03 -06:00
Forrest Bushstone f695674361
Check if c is fullscreen before reparenting it to LyrFloating 
Closes: https://github.com/djpohly/dwl/issues/487
 2023-09-29 18:01:31 -06:00
Forrest Bushstone aec21eca1f
make sure that fullscreen clients are on the correct screen when isfloating is true 
Bug: https://github.com/djpohly/dwl/issues/487
 2023-09-29 18:00:32 -06:00
Leonardo Hernández Hernández 1333f8cc6e
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-09-24 11:44:29 -06:00
Leonardo Hernández Hernández 960c32a7d8
call setfloating in setmon 
since in the previous commit we may not applying floating in clients
this is to make sure we do
 2023-09-06 22:23:37 -06:00
Leonardo Hernández Hernández aea8dd6ae1
return early if the client doesn't have monitor in setfloating 
there is still a bug, but for now this prevents a segfault

Bug: https://github.com/djpohly/dwl/issues/472
 2023-09-06 22:22:21 -06:00
Ben Collerson e5367753bb just add define 2023-08-22 22:20:39 -06:00
Ben Collerson 9be85c1117 tagcount should have been a #define 2023-08-22 22:20:39 -06:00
Leonardo Hernández Hernández 4b8c1bf31e
return nothing in xytonode() 
we do not use the node
 2023-08-22 14:48:29 -06:00
Devin J. Pohly d7569870b6
Style: use early-return to clarify code 
Use an early return to avoid indenting the main logic instead of
wrapping the tail of a function in an if statement.

No functional change, except for a handful of places where printstatus()
was being called spuriously (tag, toggletag, toggleview).

ΔSLOC: 0
 2023-08-22 01:44:31 -06:00
Devin J. Pohly 4eb54b55f3
No need to send surface.leave/enter events 
The scene graph implementation sends these for us, and it does so more
accurately than our overly-simplified approach.  Layer shell surfaces
don't appear to receive these events at all, according to my
WAYLAND_DEBUG experiments with bemenu and dtao.

ΔSLOC: -4
 2023-08-22 01:44:31 -06:00
Leonardo Hernández Hernández 4567979b16
don't resize clients on commit 
It creates an infinite commit-resize loop when scale != 1
 2023-08-18 21:37:22 -06:00
Leonardo Hernández Hernández 78cf88670f add support for xdg-shell v6 2023-07-31 18:19:41 -06:00
Leonardo Hernández Hernández ce997c4a21
update to xdg-shell v5 2023-07-23 21:15:06 -06:00
Leonardo Hernández Hernández 0e5405610e
add support for cursor-shape-v1 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4106
 2023-07-23 19:56:55 -06:00
Leonardo Hernández Hernández 0bb1a1cc5c
increase wl_compositor version 
Now scene will handle sending the preferred buffer scale

References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4269
 2023-07-15 10:11:47 -06:00
Leonardo Hernández Hernández aecff8cb26
Merge branch 'main' into wlroots-next 2023-07-13 22:36:48 -06:00
Leonardo Hernández Hernández ca4a97b933 do not use wl_event_loop for signal handling 
ΔSLOC: -4

Fixes: https://github.com/djpohly/dwl/issues/456
Fixes: https://github.com/djpohly/dwl/issues/459
 2023-07-13 22:32:48 -06:00
Devin J. Pohly 76ba2cdab0 Remove now-unneeded call to motionnotify 
This appears to have been here for the side effect of updating the drag
icon's position.
 2023-07-13 22:17:03 -06:00
Devin J. Pohly 4b15bbeb33 Remove unused icon variable 2023-07-13 22:17:03 -06:00
Devin J. Pohly 831fc36bc9 Make drag_icon a persistent scene node 
If there is no current drag icon, this node will be empty, but we now
have `drag_icon != NULL` as an invariant.  This allows us to eliminate a
conditional, since there's no harm in moving an empty node's coordinates
around with the pointer.

ΔSLOC: -1
 2023-07-13 22:17:03 -06:00
Devin J. Pohly 1841527871 properly destroy scene 
ΔSLOC: +1
 2023-07-13 17:44:21 -06:00
Leonardo Hernández Hernández ff7c0e9508
chase wlroots!4220 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4220
 2023-07-10 11:23:19 -06:00
Devin J. Pohly 33bcd2e4ca Line saver: LISTEN_STATIC macro 
This parallels the LISTEN macro for statically allocated listeners, and
it allows us to remove almost all of the global wl_listener
declarations.

This also fixes a bug with the axisnotify listener, which was declared
with a compound literal.  At block scope, these have automatic storage
duration [1], so the listener was no longer valid after setup()
returned.  (The option to declare it static explicitly was standardized
in C23, if that ever gains suckless traction.)

ΔSLOC: -27

[1]: https://en.cppreference.com/w/c/language/compound_literal#Explanation
 2023-07-08 16:56:09 -06:00
Devin J. Pohly fbd84aca4a Unify signal handling under wl_event_loop 
Merge our signal handlers into a single function and let Wayland deal
with all the struct sigaction stuff.

ΔSLOC: -3
 2023-07-03 22:28:27 -06:00
Devin J. Pohly a01e402c5d Line saver: follow "local = wlr->data = obj" pattern 
There were still a couple of places where we could use this handy
multiple assignment to save a line.

ΔSLOC = -3
 2023-07-03 21:21:43 -06:00
Leonardo Hernández Hernández 9dd3f230c0
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-06-29 13:11:55 -06:00
Devin J. Pohly eda0613cc4 Separate drag icon from layers array and Lyr enum 
If we treat the drag icon as distinct from other layers (it doesn't have
contents that are interactive, focusable, etc.), then we can iterate
over layers meaningfully with a simple for loop.

ΔSLOC: -8
 2023-06-25 17:44:00 -05:00
Leonardo Hernández Hernández 733114f0ca
schedule a frame after commmiting gamma 
not doing it, may freeze the output or do not actually change the gamma until
creating a client
 2023-06-24 10:09:49 -06:00
Leonardo Hernández Hernández fdb66ccfa3
use detached output states to set gamma 2023-06-23 13:42:44 -06:00
Leonardo Hernández Hernández 6095ff84d2
Revert "use wlr_scene_output_build_state() to set gamma" 
This reverts commit 65f68e7643.
 2023-06-23 13:30:43 -06:00
Devin J. Pohly 68a17f962e Don't bother with ignoring SIGCHLD 
It added complexity, especially with the differences in behavior between
handled and ignored signals across an exec().
 2023-06-16 00:24:17 -06:00
Devin J. Pohly 9c592da01f Reset ignored signal handler in spawn() as well 2023-06-16 00:24:17 -06:00
Devin J. Pohly df11b7a786 fix startup_cmd SIGCHLD handler 
Ignored handlers are not reset by exec() calls
 2023-06-16 00:24:17 -06:00
Leonardo Hernández Hernández 1e1811f953
drop KDE idle support 
use ext-idle-notify-v1 instead
 2023-06-15 12:32:31 -06:00
Leonardo Hernández Hernández dfb6b97159
drop support for wlr-input-inhibitor-unstable-v1 
deprecated in favor of ext-session-lock-v1

References: 4aa366e3dd
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3848
 2023-06-15 12:27:34 -06:00
Leonardo Hernández Hernández 65f68e7643
use wlr_scene_output_build_state() to set gamma 2023-06-15 12:22:43 -06:00
Leonardo Hernández Hernández 96ab92cdb1
use wlr_cursor_set_xcursor() 
This avoids re-upload the cursor image in each motion event

Managing the scale is done by the function itself

References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4170
 2023-06-15 12:12:22 -06:00
Leonardo Hernández Hernández 1eb8a82ac4
Revert "avoid setting duplicate cursor image" 
This reverts commit b5776e5180.

See next commit for details
 2023-06-15 12:02:30 -06:00
Leonardo Hernández Hernández 24a337e6ec
handle gamma-control-v1 set_gamma event 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4046
 2023-06-08 23:35:46 -06:00
A Frederick Christensen 5215712cab Stray whitespace fixes 2023-06-07 17:47:36 -06:00
Leonardo Hernández Hernández f3d017077a
use the new {a,di}ssociate events to handle xwayland commit listener 2023-06-02 22:08:17 -06:00
Leonardo Hernández Hernández 06bc65549f
chase wlroots map logic unification 
Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
 2023-06-02 22:03:41 -06:00
Leonardo Hernández Hernández a8ccbe63f3
Merge branch 'main' into wlroots-next 2023-06-02 22:01:39 -06:00
Leonardo Hernández Hernández 9b9b79b35e
activate lock surface in updatemons 
Fixes an issue when swaylock does not receive input after turn off and then
turn on the outputs
 2023-06-02 21:56:09 -06:00
Leonardo Hernández Hernández 3d98907b98
send frame done even if output commit fails 
Bug: https://github.com/djpohly/dwl/issues/420
Fixes: https://github.com/djpohly/dwl/issues/353
 2023-06-02 21:51:47 -06:00
Nikita Ivanov f8884ffc2b Set XCURSOR_SIZE 2023-06-01 19:11:33 -06:00
Leonardo Hernández Hernández 72adab621f destroy old client popups when focusing another client 
Closes: https://github.com/djpohly/dwl/issues/408
 2023-05-27 23:29:05 -06:00
Micah Gorrell 0729f18dce Prevent using a wlr_layer_surface after destroying it, due to no available outputs 2023-05-25 21:21:56 -06:00
Leonardo Hernández Hernández 2d1a40caf2
pass version to wlr_compositor_create() 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3696
Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
 2023-04-14 12:25:05 -06:00
Leonardo Hernández Hernández 733754bb06
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-04-14 12:24:19 -06:00
Leonardo Hernández Hernández 797e0c74b2
correctly check if a scene node is enabled 
checking only wlr_scene_node.enabled may result in a false positive because it
does not consider if its ancestors are enabled as well.
 2023-04-13 13:12:27 -06:00
Leonardo Hernández Hernández 3c760bcd4a
remove unneeded check of m in arrange() 
arrange must never be called with a NULL argument
 2023-04-13 13:12:27 -06:00
Ben Collerson da77e34ee5 Use uint32_t for ui Arg 2023-04-09 17:09:35 -06:00
Leonardo Hernández Hernández 20f61a59af
use fixed-size type for client tags 
while the size of `int` in most compilers is 32-bits, the size of int and all
other integer types are implementation defined, so make sure we can use up to
32-bits
 2023-04-08 11:29:18 -06:00
Ben Collerson 9d68554c59
remove tag labels from dwl 
Tag labels are not used in dwl. Only the number of tags is important.
Tag labels should be defined for each tag in whatever status bar is
used.
 2023-04-08 11:27:49 -06:00
Yves Zoundi bbdf2a913b
display clients count in monocle symbol 
- Replicate missing functionality from dwl to display the client count in monocle mode
  - Add ltsymbol field to Monitor struct
  - Display client count in monocle mode when greater than zero
- Tested with somebar and dwlb
 2023-03-16 00:02:14 -06:00
A Frederick Christensen 6722a89532 Missing apostrophe 2023-03-07 22:17:05 -06:00
Leonardo Hernández Hernández eaf6dd2cd2
do not call dmabuf_create twice 
it is called automatically by `wlr_renderer_init_wl_display()` but since we
need a pointer to wlr_linux_dmabuf_v1 to integrate it with scene API we need
to recreate that function.

Bug: https://github.com/emersion/xdg-desktop-portal-wlr/issues/216
Fixes: https://github.com/djpohly/dwl/issues/398
 2023-03-07 22:04:32 -06:00
Leonardo Hernández Hernández d1b36925c9
add support for linux-dmabuf-unstable-v1 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3726
References: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
 2023-02-20 21:24:18 -06:00
godalming123 c69a2bec3f Fix spacing and replace it with tabs 2023-02-18 18:47:44 -06:00
godalming123 737688a6b1 fix spelling 2023-02-18 18:47:44 -06:00
Leonardo Hernández Hernández fefcdbed4a
Merge remote-tracking branch 'upstream/main' into wlroots-next 2023-02-13 13:46:41 -06:00
pino-desktop f8373ccf25
Fixed 'unused variable' compiler warning. 2023-02-13 13:43:28 -06:00
Ben Collerson 7f9a212476
Add appid field to printstatus() output 
Adds an appid field to printstatus which can be used to monitor the
currently active application.
 2023-02-13 13:30:27 -06:00
Leonardo Hernández Hernández ab8334bd8a
implement repeatable keybindings 2023-02-13 13:18:43 -06:00
Leonardo Hernández Hernández 23ede80f74
allow configure x and y of outputs 2023-02-13 13:14:29 -06:00
Leonardo Hernández Hernández 04fdf1a295
add support for wp-fractional-scale-v1 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3511
 2023-02-08 22:25:41 -06:00
Leonardo Hernández Hernández fbe89a929f
chase wlroots!4000 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4000
 2023-02-05 10:03:09 -06:00
Leonardo Hernández Hernández f7d6a34cd9
use sigaction(2) for signal handling 
References: http://git.suckless.org/dwm/commit/712d6639ff8e863560328131bbb92b248dc9cde7.html
 2023-01-30 23:26:32 -06:00
Leonardo Hernández Hernández cf9c5745e5
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-30 15:29:12 -06:00
Leonardo Hernández Hernández dbe44e48c8
return early if selmon is not part of the output layout in dirtomon() 
instead of checking twice
 2022-12-30 14:31:56 -06:00
Leonardo Hernández Hernández 0b2c33248c
simplify check in urgent() 
we only care if it returned a client or not
 2022-12-30 14:29:19 -06:00
Leonardo Hernández Hernández 56114f700f
arrange monitor after updating fullscreen background and lock surfaces 2022-12-30 14:26:53 -06:00
Leonardo Hernández Hernández 71c7e4e1e5
also update locked_bg node position in updatemons() 2022-12-30 14:25:19 -06:00
Leonardo Hernández Hernández 72d29f1654
add blank lines to make updatemons() more readable 2022-12-30 14:21:46 -06:00
Leonardo Hernández Hernández e523c2b82b
update comment about client_set_size() as no-op 2022-12-30 14:19:47 -06:00
Leonardo Hernández Hernández 6d0e3a5198
check if a client is resizing before checking if it's visible 
It's not like it's noticeable, but theoretically this is faster
 2022-12-30 14:15:21 -06:00
Leonardo Hernández Hernández 5347ed663d
only mark pending resizes as completed checking the configure serial 2022-12-30 14:14:06 -06:00
Leonardo Hernández Hernández b39d270b9f
Merge branch 'main' into wlroots-next 2022-12-24 18:04:41 -06:00
Leonardo Hernández Hernández 6ca011430a
do not skip frames if a client is stopped and have a pending resize 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández 7eaa01ac1f
Revert "Revert "fix flickering when resizing/spawning windows"" 
This reverts commit 4a32293548.
 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández 92e7752203
disable client's scene node after create it (only XDGShell) 
will be enabled when setting up its monitor and arrange it

Bug: https://github.com/djpohly/dwl/issues/306
 2022-12-24 16:44:09 -06:00
Leonardo Hernández Hernández 6682878009
call arrange() or resize() depending on c->isfloating in commitnotify 2022-12-24 16:43:31 -06:00
Leonardo Hernández Hernández afacc9b0b5
force SSD when creating an xdg_toplevel_decoration object 
Closes: https://github.com/djpohly/dwl/issues/366
Not sure why GLFW apps do not get mapped when we do not tell them the
decoration method
 2022-12-20 21:53:45 -06:00
Leonardo Hernández Hernández dd9d8d543c
remove selclient() 
selclient() does not work well when dealing newly mapped
clients (specifically those mapped on invisible tags).

This fixes various bugs related to things not working because selclient() would
return NULL.

References: 94c8bd6048
 2022-12-20 21:27:14 -06:00
Leonardo Hernández Hernández 686958a4cc
fix unset fullscreen for all visible clients when mapping a new one 
this also changes our policy about when we unset fullscreen:

dwl will unset fullscreen for clients who share tags (and monitor) with a newly
mapped client, it does not matter if the clients are visible or not
 2022-12-20 21:21:40 -06:00
Leonardo Hernández Hernández 1a3d89e5b2
call checkidleinhibitor() in arrange() and not in focusclient() 2022-12-16 18:54:33 -06:00
Leonardo Hernández Hernández 7b1fe7e5f2
fix checking idle inhibit state 
checking `bypass_surface_visibility` first, could cause that even if the idle
inhibitor is being destroyed it will disable idle tracking

and if we couldn't get its scene tree, then assume that the surface is visible
 2022-12-16 17:37:18 -06:00
Leonardo Hernández Hernández 803a9ba98d
Revert "Revert "Check that inhibitor scene tree is not null"" 
This reverts commit 035bb99d67.

Not checking `tree != NULL` result in a segfault if the surface doesn't have a
role (for example because it is a newly created surface)

Closes: https://github.com/djpohly/dwl/issues/359
 2022-12-16 17:20:59 -06:00
Leonardo Hernández Hernández 94c8bd6048
get sel from focustop() in focusstack() 
Fixes: https://github.com/djpohly/dwl/issues/354
 2022-12-09 20:55:58 -06:00
Leonardo Hernández Hernández c60f651951
Revert "force line-buffered stdout if stdout is not a tty" 
This reverts commit deb48ff48b.

Fixes: https://github.com/djpohly/dwl/issues/253
 2022-12-09 08:46:22 -06:00
Leonardo Hernández Hernández 98c7adfb3d
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-06 14:21:44 -06:00
Leonardo Hernández Hernández 79b051f242
implement ext-session-lock-v1 2022-12-06 14:11:41 -06:00
Leonardo Hernández Hernández d42a977b5b
Revert "remove unneeded changes in commitnotify()" 
This reverts commit 30c24a53ad.

Bug: https://github.com/djpohly/dwl/issues/349
 2022-12-06 13:59:14 -06:00
Leonardo Hernández Hernández 4a32293548
Revert "fix flickering when resizing/spawning windows" 
This reverts commit 017bb7d752.

Bug: https://github.com/djpohly/dwl/issues/349
 2022-12-06 13:58:56 -06:00
Leonardo Hernández Hernández 9136b6247d
return early if couldn't find the popup's parent 2022-12-06 13:34:35 -06:00
Leonardo Hernández Hernández 19b5d47a9e
fix popups appearing outside the monitor 
and a potentially crash
 2022-12-06 13:31:48 -06:00
Leonardo Hernández Hernández b5229636a3
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-05 23:43:47 -06:00
Leonardo Hernández Hernández 22336612ae
improve type safety of toplevel_from_wlr_surface() 2022-12-05 23:18:02 -06:00
Leonardo Hernández Hernández 38bd00351a
merge toplevel_from_{wlr_layer_surface,popup} into client_from_wlr_surface 
now it is a big function called toplevel_from_wlr_surface
 2022-12-05 23:18:01 -06:00
Leonardo Hernández Hernández 13b929d7d7
remove unneeded call to wlr_scene_rect_set_color() 
wlr_scene_rect_create() requires a color as parameter
 2022-12-05 23:06:53 -06:00
Leonardo Hernández Hernández b6d6127733
add option for set button map 2022-12-05 22:22:49 -06:00
Leonardo Hernández Hernández 02c257e0b1
update for wlroots!3627 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3627
 2022-12-05 20:21:38 -06:00
Dima Krasner 16a49e9955 fix null deref in sigchld() if Xwayland is disabled 2022-12-03 13:30:30 -06:00
Palanix 30c24a53ad
remove unneeded changes in commitnotify() 2022-12-03 13:14:10 -06:00
Palanix 017bb7d752
fix flickering when resizing/spawning windows 
Fixes: https://github.com/djpohly/dwl/issues/306
 2022-12-03 13:14:10 -06:00
Leonardo Hernández Hernández fac3b6f2cf
use root surfaces to check idle inhibitors 
References: https://github.com/djpohly/dwl/pull/343
 2022-12-02 23:25:46 -06:00
Leonardo Hernández Hernández 035bb99d67
Revert "Check that inhibitor scene tree is not null" 
This reverts commit 9c155eefdc.

This commit was applied just a workaround, the proper fix is the next commit
 2022-12-02 23:25:04 -06:00
Leonardo Hernández Hernández 27ab9cf1b1
call updatemons() in requestmonstate() 
This way we make sure that the Monitor's boxes are updated correctly
 2022-12-02 23:17:05 -06:00
Ben Jargowsky 9c155eefdc Check that inhibitor scene tree is not null 2022-12-02 15:10:25 -06:00
Leonardo Hernández Hernández 1b39bbf316
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-12-02 10:39:06 -06:00
Leonardo Hernández Hernández eaf8a21603
unset fullscreen when mapping a client in the same monitor 
Fixes: https://github.com/djpohly/dwl/issues/327
 2022-12-02 10:09:50 -06:00
Leonardo Hernández Hernández ce1d040586
Merge branch 'main' of github.com:djpohly/dwl 2022-12-02 10:06:40 -06:00
Leonardo Hernández Hernández 6df6781b43
simplify check for surface's node state 
all `struct wlr_surface` should have a `wlr_scene_tree *` as data
 2022-11-30 18:54:54 -06:00
Leonardo Hernández Hernández 10c56d6348
add option to allow invisible surfaces to disable idle tracking 2022-11-30 18:51:35 -06:00
Leonardo Hernández Hernández c91d21b68f
do not move/resize if grabbed client is fullscreen 2022-11-30 17:54:47 -06:00
Leonardo Hernández Hernández 3213088aa2
do not try to set the parent's same tags and monitor for xwayland clients 
References: https://github.com/djpohly/dwl/pull/334#issuecomment-1330166324
 2022-11-30 17:42:58 -06:00
krypek 87d87cc404 Fix comparison between signed and unsigned int 
When c->bw is 0, the right side of the MAX functions gets turned into an unsigned integer and that results in -1 being the outcome.
This causes big issues in xwayland clients.
 2022-11-25 12:09:35 -06:00
Leonardo Hernández Hernández ea1b2dda63
Merge branch 'main' into wlroots-next 2022-11-21 20:51:30 -06:00
Leonardo Hernández Hernández 087373698a
Revert "Add a configuration option for fullscreen locking" 
now all fullcreen clients are rendered above tiled and floating clients

This partially reverts commit 326eee1444.
 2022-11-21 20:50:39 -06:00
Leonardo Hernández Hernández caec566286
create a dedicated layer for fullscreen clients 
Bug: https://github.com/djpohly/dwl/issues/327
 2022-11-21 20:50:26 -06:00
Leonardo Hernández Hernández 05eca0e2d9
rename xwayland_surface to xsurface 
this save us 2 lines
 2022-11-21 14:28:05 -06:00
Leonardo Hernández Hernández 7eebe67787
set x and y of the layersurface's geometry box 2022-11-21 14:28:05 -06:00
Leonardo Hernández Hernández 63d6de5866
fix set of layersurface->popups and surface->data 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández 60a98b87f3
inhibit idle if surface's node is enabled 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández 93a911d6e9
simplify if expression in checkidleinhibitor() 2022-11-21 14:28:04 -06:00
Leonardo Hernández Hernández 88d386bfdc
configurex11: resize floating clients and arrange tiled clients' monitor 2022-11-21 14:27:57 -06:00
Leonardo Hernández Hernández 972e3f3050
Merge branch 'wlroots-next' into main 2022-11-21 14:16:55 -06:00
Leonardo Hernández Hernández 569f554016
don't unfocus focused client when starting a drag 
this fix chromium keyboard focus loss after a drag
Fix: 3cc22de712
 2022-11-19 01:34:15 -06:00
Leonardo Hernández Hernández 21ef004886
listen to the output request_state event; 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/2693
 2022-11-15 23:52:21 -06:00
Leonardo Hernández Hernández dae00caadd
update for wlroots!3861 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3861
 2022-11-15 23:07:45 -06:00
Leonardo Hernández Hernández 5eb3529275
use the new scene helper for drag icons 2022-11-15 23:07:21 -06:00
Leonardo Hernández Hernández 359e7edc52
update for wlroots!3814 
References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3814
 2022-11-15 23:04:39 -06:00
Leonardo Hernández Hernández 25dfdcc433
specify layer shell version 2022-11-15 23:04:02 -06:00
Leonardo Hernández Hernández fcb3fa4e90
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-11-10 23:25:48 -06:00
shua f1639ba9d5
check null in toplevel_from_popup 
managed to SEGFAULT the server by trying to create a popup
without setting a parent first.

Not sure if this is dwl or wlroots issue, so also opened a ticket upstream: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3811
 2022-11-09 00:01:50 -06:00
Leonardo Hernández Hernández 8bd3442575
layersurface: create a dedicated scene tree for popups 
this tree should be always above the top layer

Fixes: https://github.com/djpohly/dwl/issues/328
 2022-11-01 12:52:25 -06:00
Leonardo Hernández Hernández 3cc22de712
client: don't change border color during drags 
Fixes: https://github.com/djpohly/dwl/issues/318
 2022-10-31 23:46:02 -06:00
Leonardo Hernández Hernández 448a96de13
remove now unneeded workaround in outputmgrapplyortest() 2022-10-30 01:03:44 -05:00
Leonardo Hernández Hernández 99f062273e
only destroy monitor's layer surfaces at destroy 2022-10-29 19:02:44 -05:00
Leonardo Hernández Hernández 8298f20a71
allow change adaptive sync in outputmgrapplyortest() 2022-10-29 18:30:09 -05:00
Leonardo Hernández Hernández 6a0ec2a8c3
Merge remote-tracking branch 'upstream/main' into wlroots-next 2022-10-29 18:11:28 -05:00
Leonardo Hernández Hernández 846ce52b92 fix crash in dirtomon() when selmon is disabled 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández a9e2ebaf41 closemon() now updates selmon if needed 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández 9b5f0f0fc5 use just one loop in outputmgrapplyortest() 
we do the magic in updatemons()
 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández cb01ce9bcf move focus and clients off disabled monitors 2022-10-29 16:48:50 -05:00
Leonardo Hernández Hernández 9588b46b5c
only raise the client's node in monocle() 
Fixes: https://github.com/djpohly/dwl/issues/326
 2022-10-29 16:47:17 -05:00
Leonardo Hernández Hernández 1eeb3689d3
add support for the ext-idle-notify-v1 protocol 
for now we use macros to support both KDE idle and ext-idle, wlroots will
likely drop support for KDE idle in 0.17
 2022-10-23 14:41:28 -05:00
Leonardo Hernández Hernández e9826de295
Revert "stop trying resize clients during commitnotify()" 
This reverts commit 2d9d758c8d.

wasn't meant to be pushed to main
 2022-10-15 18:25:58 -05:00
Leonardo Hernández Hernández 110cde8f67
update comment about exclusive focus in focusclient() 2022-10-15 18:09:42 -05:00
Leonardo Hernández Hernández 2d9d758c8d
stop trying resize clients during commitnotify() 
instead resize them in configurex11()
 2022-10-15 18:00:55 -05:00
Leonardo Hernández Hernández 332ceb7136 allow unmanaged clients (like dzen or dmenu) to have keyboard focus 2022-10-15 18:00:24 -05:00
Leonardo Hernández Hernández 4eabf6f7eb
disable and destroy monitor's layer surfaces when it's being destroyed 
Fixes: https://github.com/djpohly/dwl/issues/314
 2022-10-11 13:11:14 -05:00
Leonardo Hernández Hernández 765656902f
use /* */ for comments in applybounds() 2022-10-08 20:51:40 -05:00
Leonardo Hernández Hernández 1438dfc150
fix bad indentation in createpointer() 2022-10-08 20:51:05 -05:00
Leonardo Hernández Hernández 3902fba769
rename dragicondestroy() -> destroydragicon() 
to match the rest of the code
 2022-10-08 20:50:17 -05:00
Leonardo Hernández Hernández 7f3c9fa0ae
rename LyrNoFocus -> LyrDragIcon 2022-10-08 20:48:48 -05:00
Leonardo Hernández Hernández 952fde68a3
correctly handle cursor motion when button is held (for layer surfaces) 2022-10-08 13:02:43 -05:00
Dima Krasner 0d1ca4663c
allow moveresize() while the left mouse button is pressed 
Fixes: https://github.com/djpohly/dwl/issues/319
 2022-10-08 12:31:29 -05:00
Leonardo Hernández Hernández f6820a6c29
fix drag and drop not working 
this fixes another issue where the cursor doesn't change when selecting text
but there is still an issue about not changing border color of clients during
dnd operations

Bug: https://github.com/djpohly/dwl/issues/318
 2022-10-07 10:45:45 -05:00
Leonardo Hernández Hernández 8559141b30
avoid usage of goto 
Based on this suggestion: bc72af6e24 (commitcomment-85592855)
 2022-10-03 23:28:58 -05:00
Leonardo Hernández Hernández 434ed119f3
wlroots check map state of layersurfaces this for us 2022-10-01 23:33:17 -05:00
Leonardo Hernández Hernández ae3d435717
Merge remote-tracking branch 'djpohly/main' into wlroots-next 2022-10-01 23:30:47 -05:00
Leonardo Hernández Hernández b8bc54b65d properly handle cursor motion when button is held 
Based on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3653
 2022-10-01 23:10:54 -05:00
Leonardo Hernández Hernández b5776e5180
avoid setting duplicate cursor image 
Reference: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3436
Based on: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3595
 2022-09-28 17:11:04 -05:00
Leonardo Hernández Hernández c13d948ea9
destroy renderer and allocator in cleanup() 2022-09-28 14:15:25 -05:00
Leonardo Hernández Hernández fc8b2a8335
fix bad condition 2022-09-26 20:31:36 -05:00
Leonardo Hernández Hernández c00faae263
fix various segfaults when selmon is NULL 2022-09-26 19:07:45 -05:00
Leonardo Hernández Hernández e46238b95e
change cursor surface in internal calls of motionnotify() 
and call motionnotify() after unmapping a client
and when focusing a client

Fixes: https://github.com/djpohly/dwl/issues/308
 2022-09-26 13:17:07 -05:00
Leonardo Hernández Hernández 2385d82612
remove unused variables 2022-09-20 23:40:35 -05:00
Leonardo Hernández Hernández 1fdc65ff93
make more permissive exclusive focus 
now you can call focusstack() while a layer surface is focused and when it gets
unmapped the newly focused clients will be actually focused
 2022-09-18 17:25:12 -05:00
Leonardo Hernández Hernández fbaeb85363
now really fix clients not being focused after unmapping a layer surface 2022-09-18 17:23:07 -05:00
Leonardo Hernández Hernández 570e6e2c27
fix clients not being focused after destroy a layer surface 2022-09-18 16:52:54 -05:00
Leonardo Hernández Hernández a1b33826cf
Revert "remove useless check of m in arrangelayers()" 
This partially reverts commit d14ee99661.

Checking if the output is enabled is necessary to avoid a segfault later
 2022-09-18 16:36:38 -05:00