Commit graph

968 commits

Author SHA1 Message Date
Stivvo 0ad8473a57 Delete quitfullscreen()
quitfullscreen() was replicating the functionalities of setfullscreen(c,
0)

Reusing setfullscreen() in quitfullscreen() leads to a 3 line function,
which is useless since quitfullscreen() is used once anyway
2020-10-14 15:46:35 +02:00
Stivvo a2ed3d45bb Keep windows fullscreen after redraw
This fixes the bug that happens when changing workspace (or any time
arrange() is called) where there are fullscreen windows, which are still
fullscreen but leave the space for layer surfaces like waybar (which
should be hidden when going fullscreen)

Also as soon one fullscreen window is found hte function returns to
improve efficiency
2020-10-08 21:04:53 +02:00
Stivvo 172bcfd3ff Set fullscreen simpler 2020-10-08 21:04:28 +02:00
Stivvo 2b286ffeed use m->m (fullscreen on top of layers) 2020-09-16 09:20:09 +02:00
Stivvo 405280fd09
Merge pull request #1 from guidocella/fullscreen
fix typo
2020-09-16 08:55:01 +02:00
Stivvo d8f752c9b4 Keep client tags on unplug
When unplugging a monitor, each client is moved to the same tag number
as before on the new monitor
2020-09-15 12:28:58 +02:00
Stivvo bece225934 Handle monitor unplug
Floating widndows with "x < removed monitor's width" aren't resized
(they used to disappear in negative coordinates).

Actually delete monitors when they are unplugged, recalculate sgeom and
give a new monitor to clients that were on the removed one with setmon()

arrangefloat() funcion has been exploded to save iterations in
cleanupmon().

Also if a monitor that supports auto suspension is turned off, dwl will
count it as unplugged (it will become unreachable and all clients will
be moved to the leftmost monitor). However, if at least one monitor
isn't plugged in, dwl will still crash the same as before.

Unlike sway, when the output configuration is changed and restored,
(unplug + plug the same monitor for example) previous application
positions aren't kept. This is due to the fact that on sway every
workspace is unique among all monitors.
2020-09-15 12:28:49 +02:00
Oyren a2e5c25e26
remove log flags from readme
The following commit has removed the logs but they are still in the readme.
3b1992ca91
2020-09-14 20:45:39 +02:00
Stivvo 537ad7e3fd Restore floating win position after mon add
Compensate the coordinate changes when adding a new monitor.

Every test so far confirms that monitors are always added to the left,
on top of the list, so every floating window's x coordinate has to be
incremented by the width of the new monitor.
2020-09-12 00:21:58 +02:00
Guido Cella 0bb25a73ec extract function and comment it 2020-09-11 14:52:59 +02:00
Guido Cella e4d58c39e0 remove braces 2020-09-11 13:15:31 +02:00
Guido Cella fbd905155a fix multi monitors even more
When a monitor is created or removed, the geometries of the old ones
must be updated. This is also more efficient than before since we
calculate the monitor geometries only when creating and destroying
monitors. arrangelayers() is needed to recalculate m->w. arrange() is so
clients don't move to the left monitor when plugging or unplugging
monitors (clients keep the same coordinates but the field below them
changes).
2020-09-11 13:09:18 +02:00
Guido Cella 8d8d24db09 fix typo 2020-09-10 09:09:46 +02:00
Guido Cella 8f0ce672d3 simplify 2020-09-10 06:01:18 +02:00
Guido Cella 143dce094c fix multi monitors further
Fix layer surfaces without an exculsive area by using the right x and y
for the current monitor (by Stivvo).
2020-09-09 17:13:30 +02:00
Bonicgamer 4915214e47
Made scalebox the way sway does it 2020-09-08 14:53:34 -04:00
Guido Cella 62250661cf remove unneeded line
The bug was caused by usable_area's x and y not being set in
arrangelayers. For example if on a 2nd HD monitor, x should be 1920
while the first one ends at 1919. So I don't see why m->m should be
recalculated after creating the monitor.
2020-09-08 13:36:46 +02:00
Guido Cella 68412d8957 try to fix again
Calculate x and y of usable_area, not just width and heigth.
2020-09-08 12:49:05 +02:00
Guido Cella 69847872bb fix multi monitors
If you don't recalculate the monitor's geometry before arranging,
clients get arranged in the first monitor. I don't understand why this
fixes the bug since tile() uses m->w rather than m->m, nor why it needs
to be recalculated after creating the monitor but sway does it too.

Although not necessary to fix the bug I also made arrangelayer() do like
sway again and recalculate usable_area instead of reusing m->m, since
m->m seems to be incorrect until it gets recalculated shortly after in
arrange(), so I suspect that leaving usable_area = m->m will cause
issues under certain circumstances.

Someone with a multi-monitor setup or better knowledge of Wayland may be
able to figure out the cause of the bug. For now, this makes layer shell
work.
2020-09-08 10:28:29 +02:00
Guido Cella 79f3bbaf38 remove variable 2020-09-06 19:59:58 +02:00
Stivvo d8570d5ceb Allow borderpx = 0 2020-09-06 12:20:41 +02:00
Guido Cella 52a4d3a1e5 use size_t for lengths 2020-09-05 18:29:39 +02:00
Guido Cella 9743778d09 rename variable and merge 2 lines 2020-09-05 14:15:03 +02:00
Stivvo 621d4c9173 Toggle fullscreen on all clients
mod+e allows to toggle fullscreen any client, even those who don't
support it themselves
2020-09-05 11:22:24 +02:00
Stivvo d9cf3e064c Handle new windows
Windows lose fullscreen state when a new window is created in the same
tag
2020-09-05 11:02:13 +02:00
Stivvo 73d717a924 isfullscreen int 2020-09-05 10:40:52 +02:00
Stivvo bd222cb75d Same fscreen func for xdg and xwayland 2020-09-05 10:40:52 +02:00
Stivvo dd2adb38ae Fullscreen xwayland 2020-09-05 10:40:52 +02:00
Stivvo aeae3dadbb Unlink fullscreen 2020-09-05 10:37:59 +02:00
Guido Cella 6b25e7ef27 simplify 2020-09-05 06:58:54 +02:00
Guido Cella 8ee0200877 use unsigned int for loop indexes 2020-09-04 21:36:43 +02:00
Guido Cella ae798c694a Don't let overlays lose focus
if you open a new window while an overlay is mapped, the overlay should
stay focused
2020-09-04 21:35:48 +02:00
Guido Cella 8de18f9bb4 fix restoring pointer focus
I don't know why I thought it was working before. Maybe I should go do
something else.
2020-09-04 21:14:02 +02:00
Guido Cella 71572521e9 improve code style 2020-09-04 18:45:30 +02:00
Guido Cella 9308a90d11 remove comment
I don't know why it wasn't working before but now it does ¯\(ツ)/¯
(it wasn't caused by the just removed code either)
2020-09-04 18:04:20 +02:00
Guido Cella 8e81c90f31 remove mysterious code
Why would a surface that's not keyboard interactive get focused? Let's
remove this for now and see if issues arise.
2020-09-04 17:38:37 +02:00
Guido Cella 2d84c74657 focus the previous client in the similar code too 2020-09-04 17:38:04 +02:00
Guido Cella 068352e888 refocus old client
When a layer surface is destroyed focus should be returned to the last
client. Luckily if there are multiple overlays the previous overlay
still gets focused.
2020-09-04 17:21:48 +02:00
Stivvo 43bd806291 Restore windows after fullscreen
Store position and size of windows before going fullscreen. This is more
efficient than arrange() and also works with floating windows

All the clients keep their original position because arrange() isn't
used after quitting fullscreen
2020-09-04 17:11:26 +02:00
Stivvo 4b1ab7804b No borders on fullscreen windows
Some code has been borrowed from the smartBorders patch
2020-09-04 17:09:42 +02:00
Guido Cella 4341deae8f fix alhpabetical order 2020-09-04 17:01:34 +02:00
Guido Cella 5dc9460044 simplify focus leave condition 2020-09-04 16:42:14 +02:00
Guido Cella 35b93669f1 reuse motionnotify() 2020-09-04 15:35:04 +02:00
Stivvo 06982a56b5 Toggle fullscreen 2020-09-04 14:04:19 +02:00
Stivvo 60f0b667b1 Basic fullscreen 2020-09-04 12:44:09 +02:00
Guido Cella d98ca07a64 enable pointer on layer surfaces 2020-09-04 07:42:51 +02:00
Guido Cella b26ede4727 more TODOs 2020-09-03 18:59:27 +02:00
Guido Cella 4017a27b67 fix focus leave condition
needs refactoring and testing
2020-09-03 18:58:27 +02:00
Guido Cella b4d9a8662f send pressed keys to topmost layer surface 2020-09-03 18:34:41 +02:00
Guido Cella d74d404026 update README 2020-08-29 08:47:28 +02:00